hoaproject / Contributions-Atoum-PraspelExtension

Include Praspel inside atoum.
4 stars 5 forks source link

Remove call to Hoa\Core #12

Closed vonglasow closed 8 years ago

vonglasow commented 8 years ago

Still have dependencies to Hoa\Core in binary Praspel.php

Bin/Praspel.php
60:use Hoa\Core;
65:Core::enableErrorHandler();
66:Core::enableExceptionHandler();
88:catch ( Core\Exception $e ) {

Bin/Command/Generate.php
40:use Hoa\Core;
140:        $phpBinary = Core::getPHPBinary() ?:
147:        $envVariable   = '__ATOUM_PRASPEL_EXTENSION_' . md5(Core::uuid());
151:        $reflectionner->on('input', function ( Core\Event\Bucket $bucket )
166:        $reflectionner->on('output', function ( \Hoa\Core\Event\Bucket $bucket )

Exception.php
42: * Extending the \Hoa\Core\Exception class.
49:class Exception extends \Hoa\Core\Exception { }

Autoloader.php
46:if(is_file($vendorAutoloader = $vendorDirectory . '/hoa/core/Core.php'))
47:    require_once $vendorDirectory . '/hoa/core/Core.php';
55:    ->addDirectory('Hoa\Core', $vendorDirectory . '/hoa/core')

Praspel/Generator.php
40:use Hoa\Core;
150:            catch ( Core\Exception $e ) {
223:            catch ( Core\Exception $e ) {

Replace Core usage in files

Use Hoa\Exception\Idle::enableUncaughtHandler for exceptions Use Hoa\Exception\Error::enableErrorHandler for errors

Hywan commented 8 years ago

Oops. Could you provide a patch?

vonglasow commented 8 years ago

Yeap, in progress, I don't know if I will have enough time today to finish it. But I will try to create a PR.

Hywan commented 8 years ago

Thanks!