search

hoaproject / Irc

The Hoa\Irc library.
https://hoa-project.net
25 stars 9 forks source link

Update `Irc\Client` constructor behaviour. #20

Closed shulard closed 8 years ago

shulard commented 9 years ago

Previously the constructors must be called with an instance of Socket\Client as the first parameter. Now it can handle string too.

Jir4 commented 8 years ago

@shulard why ?

shulard commented 8 years ago

@Jir4 it's related to the PR: hoaproject/Websocket#50

We've updated the Websocket\Client and Websocket\Server behaviour to be able to handle string (socket URL) as client. I though it's a nice idea here too :smile:

Jir4 commented 8 years ago

ok :+1: so ^^

Hywan commented 8 years ago

Maybe we can register irc:// too? Does it make sense?

shulard commented 8 years ago

I think it make sense... It'll simplify usage :smile:

I'll work on that :+1: Also, that PR must be updated with the latest feedback on the hoaproject/Websocket#50. I do that today :smile:.

Jir4 commented 8 years ago

:+1: to irc://

shulard commented 8 years ago

Hello !

As I've said in the hoaproject/Websocket#50 PR, the initialization process is not complicated enough to introduce that kind of behaviour. I close that PR too !

The #22 was created to introduce irc transport wrapper which is more important :smile:.