search

hoaproject / Irc

The Hoa\Irc library.
https://hoa-project.net
25 stars 9 forks source link

Typo in `composer.json` fix #23 #24

Closed Jir4 closed 8 years ago

Jir4 commented 8 years ago

As explained in #22 by @shulard, there's a typo in the composer.json, we should use hoa/socket : ~1.0.

Hywan commented 8 years ago

@Jir4 Please, start from an up-to-date master branch.

Jir4 commented 8 years ago

It's a whole new fork ôO

Hywan commented 8 years ago

Now can you rebase in one commit please :-)?

Jir4 commented 8 years ago

Uhm, not sure about what to do, i'll try :s

Hywan commented 8 years ago

@Jir4 git rebase -i HEAD~2 and then use fixup.

Hywan commented 8 years ago

(http://hoa-project.net/En/Literature/Contributor/Guide.html#Rebase_when_asked)

Jir4 commented 8 years ago

Was exactly on this section of the contributor guide ^^, i just don't know wich one i have to fixup

Jir4 commented 8 years ago

:* CTRL+S missing here

Hywan commented 8 years ago

Fixed by https://github.com/hoaproject/Irc/commit/f74dc090c36be55d475ed3fd7c7502fca99b98e6. I changed the commit title.

Hywan commented 8 years ago

Thanks!

Hywan commented 8 years ago

Snapshot 0.16.02.03 released: https://github.com/hoaproject/Irc/releases/tag/0.16.02.03.

Jir4 commented 8 years ago

\o/