Closed jubianchi closed 8 years ago
\o/
I propose the following structure:
Test/
Report/
Cli/
Cli.php
Fields/
Result.php
Uncompleted.php
etc.
I guess this is much better. See comments for an explanation. Thoughts?
Here is the result with my terminal palette: … I am not sure this is a good idea to tweak the colours this way. Why not keeping the regular limited colour palette (with 16 colours)? I guess we will have better results.
Thoughts?
Or at least, change the “pink” by something more contrasted. Because the green is very beautiful :-p.
Yes, please, just change the “pink”/“violet” colours. This is not enough contrasted.
Here is the result with a failing test case: Very correct.
indeed, more contrasted, but I wonder if this is the correct color :-p. What about an orange, like B27E28 or C61C6F?
@Hywan what about
What about C61C6F for the logo and 6CBE6C for the “info”?
Else, go with your last proposal. We can change later if it appears to not be clear.
A reminder for the documentation (FR):
14:12 jubianchi: [06:00:52] Hywan: of course
14:12 jubianchi: [06:00:54] j'avais pas vu qu'il y avait de la doc
14:12 jubianchi: [06:04:45] Hywan: qu'entends-tu pas "inconclusive" ?
14:12 jubianchi: [06:04:58] le terme est associé au "void test cases"
14:12 jubianchi: [06:05:23] pour moi ça veut dire qu'on n'est pa sarrivé à déterminer le status du test, mais c'est à moitié faux :
14:12 jubianchi: [06:05:42] une methode void dans atoum est considérée comme OK car elle n'a pas produit d'erreur ou levé d'exception
14:12 jubianchi: [06:05:59] par contre, elle ne contient aucune assertion native d'atoum donc elle est dite "void"
14:12 jubianchi: [06:06:10] mais ça ne veut pas dire qu'lle ne vérifie rien
14:12 jubianchi: [06:06:29] ou que sont status est indéterminé ou quoi...
14:12 jubianchi: [06:06:39] c'est un détail mais si tu veux je précise ça en même temps
Backgrounds ? I think not :p
@jubianchi
Here is what it looks like now :
@jubianchi Do we wait atoum/atoum#501 to be merged before closing this one? Or do we open another PR?
@Hywan I think we should wait : i'll try to backport the patch here today ;)
@jubianchi Perfect :-).
Few more comments to address before the patches being ready to be merge.
ping?
I'll clear all I have to on @hoaproject this week-end ;)
Good :-]. Thanks!
@Hywan I can go any further here as console has not been tagged with the new Output
class.
@jubianchi Use dev-master
.
@jubianchi What about now :-)?
adding the atoum version on the report?
@jubianchi Sorry… ping :heart:?
@Hywan any news?
Thanks!
2 PRs have been opened after this one:
Resulting output looks like this:
:+1:
See #40 for the disucssion. The goal is to provide a custom CLI report for atoum which uses a more appropriate wording in the context of Hoa's tests.
So here it is :)
Basically, this report is the same as the default atoum CLI report but some things changed:
A screenshot is worth a thousand words:
hoa/json
Edit from @Hywan: Fix #40.