hoaproject / Test

The Hoa\Test library.
https://hoa-project.net/
11 stars 10 forks source link

Add custom atoum report #46

Closed jubianchi closed 8 years ago

jubianchi commented 9 years ago

See #40 for the disucssion. The goal is to provide a custom CLI report for atoum which uses a more appropriate wording in the context of Hoa's tests.

So here it is :)

Basically, this report is the same as the default atoum CLI report but some things changed:

A screenshot is worth a thousand words:

Edit from @Hywan: Fix #40.

Hywan commented 9 years ago

\o/

Hywan commented 9 years ago

I propose the following structure:

Test/
    Report/
        Cli/
            Cli.php
            Fields/
                Result.php
                Uncompleted.php
                etc.

I guess this is much better. See comments for an explanation. Thoughts?

Hywan commented 9 years ago

Here is the result with my terminal palette: screen shot 2015-09-23 at 13 13 30screen shot 2015-09-23 at 13 13 38 I am not sure this is a good idea to tweak the colours this way. Why not keeping the regular limited colour palette (with 16 colours)? I guess we will have better results.

Thoughts?

Hywan commented 9 years ago

Or at least, change the “pink” by something more contrasted. Because the green is very beautiful :-p.

Hywan commented 9 years ago

Yes, please, just change the “pink”/“violet” colours. This is not enough contrasted.

Hywan commented 9 years ago

Here is the result with a failing test case: screen shot 2015-09-23 at 13 17 45 Very correct.

Hywan commented 9 years ago

screen shot 2015-09-23 at 14 28 03 indeed, more contrasted, but I wonder if this is the correct color :-p. What about an orange, like B27E28 or C61C6F?

jubianchi commented 9 years ago

@Hywan what about

hoa_atoum_white

Hywan commented 9 years ago

What about C61C6F for the logo and 6CBE6C for the “info”?

Hywan commented 9 years ago

Else, go with your last proposal. We can change later if it appears to not be clear.

jubianchi commented 9 years ago

A reminder for the documentation (FR):

14:12 jubianchi: [06:00:52] Hywan: of course
14:12 jubianchi: [06:00:54] j'avais pas vu qu'il y avait de la doc
14:12 jubianchi: [06:04:45] Hywan: qu'entends-tu pas "inconclusive" ?
14:12 jubianchi: [06:04:58] le terme est associé au "void test cases"
14:12 jubianchi: [06:05:23] pour moi ça veut dire qu'on n'est pa sarrivé à déterminer le status du test, mais c'est à moitié faux :
14:12 jubianchi: [06:05:42] une methode void dans atoum est considérée comme OK car elle n'a pas produit d'erreur ou levé d'exception
14:12 jubianchi: [06:05:59] par contre, elle ne contient aucune assertion native d'atoum donc elle est dite "void"
14:12 jubianchi: [06:06:10] mais ça ne veut pas dire qu'lle ne vérifie rien
14:12 jubianchi: [06:06:29] ou que sont status est indéterminé ou quoi...
14:12 jubianchi: [06:06:39] c'est un détail mais si tu veux je précise ça en même temps
jubianchi commented 9 years ago

Backgrounds ? I think not :p

bad_idea
Hywan commented 9 years ago

@jubianchi no

jubianchi commented 9 years ago

Here is what it looks like now :

hoa_underline

jubianchi commented 9 years ago
arrows
Hywan commented 9 years ago

@jubianchi Do we wait atoum/atoum#501 to be merged before closing this one? Or do we open another PR?

jubianchi commented 9 years ago

@Hywan I think we should wait : i'll try to backport the patch here today ;)

Hywan commented 9 years ago

@jubianchi Perfect :-).

Few more comments to address before the patches being ready to be merge.

Hywan commented 8 years ago

ping?

jubianchi commented 8 years ago

I'll clear all I have to on @hoaproject this week-end ;)

Hywan commented 8 years ago

Good :-]. Thanks!

jubianchi commented 8 years ago

@Hywan I can go any further here as console has not been tagged with the new Output class.

Hywan commented 8 years ago

@jubianchi Use dev-master.

Hywan commented 8 years ago

@jubianchi What about now :-)?

Grummfy commented 8 years ago

adding the atoum version on the report?

Hywan commented 8 years ago

@jubianchi Sorry… ping :heart:?

jubianchi commented 8 years ago

@Hywan any news?

Hywan commented 8 years ago

Thanks!

Hywan commented 8 years ago

2 PRs have been opened after this one:

Hywan commented 8 years ago

Resulting output looks like this: screen shot 2016-03-02 at 11 21 21

vonglasow commented 8 years ago

:+1: