search

hodcroftlab / covariants

Real-time updates and information about key SARS-CoV-2 variants, plus the scripts that generate this information.
https://covariants.org/
GNU Affero General Public License v3.0
316 stars 112 forks source link

URLs not working on 'Cases' page #299

Closed emmahodcroft closed 2 years ago

emmahodcroft commented 2 years ago

URLs on Per Country and Per Variant pages allow the URL to modify if users specify particular countries/variants. This should work the same on the Cases page. Indeed, selecting countries does change the URL at the top (and view). However, when putting that URL in a new window, it doesn't actually filter to just showing what's in the URL.

Compare URLS:

On Cases page: https://covariants.org/cases?country=USA&country=Canada&country=Japan&country=Croatia Should show: image (but shows all countries)

But on Per Country Page: https://covariants.org/per-country?country=USA&country=Canada&country=Japan&country=Croatia Works as expected and shows: image

It also doesn't work on Cases page for variants: https://covariants.org/cases?variant=21A+%28Delta%29&variant=21I+%28Delta%29&variant=21J+%28Delta%29

I'm hopeful this is just a plumbing issue - the 'Cases' page just wasn't fully hooked up into the URL system, and can be without too much work!

ivan-aksamentov commented 2 years ago

Should be resolved in #300