search

hodcroftlab / covariants

Real-time updates and information about key SARS-CoV-2 variants, plus the scripts that generate this information.
https://covariants.org/
GNU Affero General Public License v3.0
316 stars 111 forks source link

Optional Three Letter Abbreviation for amino acid right table #330

Closed carlos-montano-hub closed 2 years ago

carlos-montano-hub commented 2 years ago

Added a button to change the right table from One Letter Abbreviation to Three Letter Abbreviation in order to solve #323

image image

In case of this PR being accepted, please accept #325 first, as I copied the code from there and in that way @chatelao would not lose his contribution

Any feedback please let me know

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
covariants ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 1:21AM (UTC)
ivan-aksamentov commented 2 years ago

I was hoping that we could implement a global toggle for all badges. Was this not the intent?

Perhaps the side bar on these particular pages is not the best place for a toggle, because when switching to other pages user loses access to the toggle.

ivan-aksamentov commented 2 years ago

In case of this PR being accepted, please accept https://github.com/hodcroftlab/covariants/pull/325 first, as I copied the code from there and in that way @chatelao would not lose his contribution

You could have based your branch on chatelao's branch. This would simplify things a lot. It's not too late to rebase.

emmahodcroft commented 2 years ago

Hi @carlos-montano-hub - thank you for this PR! I think it really shows that the transition between the 1-letter and 3-letter abbreviations can be smooth, and that the side-bar with the mutations on the Variants pages looks good in both formats. I tried the current preview at a variety of resolutions/mobile devices and I think it looks good.

However I do think it's worth addressing some of Ivan's concerns above. In particular, it would be great for this to be a switch that adjusts how the badges display so that all badges across all parts of the page (in the text, in the non-defining mutation counts) and even across pages (Shared Mutations page) can change when the user requests a change, so that it's a 'universal state' across the site. Do you think that's possible?

I also agree that a slider or radio button might work better as it more clearly indicates the current selection, and might also be able to be made a little more compact, to fit at the top(-ish) of the relevant pages (each Variant page & the Shared Mutations page, I think) where it would be used.

However I think this shows really well, as I said, that the 3-letter abbreviations look good and the transitioning can be smooth, which makes it an idea worth pursuing and a great start! I'm hopeful to see it become something we can get integrated!

carlos-montano-hub commented 2 years ago

Hello, thanks for the feedback @ivan-aksamentov @emmahodcroft I will be working on it and let you know