search

hodooor / Hodoor

Server side for Hodoor - Casual attendance system
GNU General Public License v3.0
8 stars 6 forks source link

Frontend design #1 pull request #42

Closed patriczek2811 closed 7 years ago

patriczek2811 commented 7 years ago

Please checkout my work and pull it if possible.

OndrejVicar commented 7 years ago

Loading time of some pages is really slow now. I think you should remove scripts which are not needed on all pages from base.html and add them to specific pages when needed.

Also really almost all javascript should be in static resources /attendance/static/js/ - for example script from sessions.html.

Another problem are failing existings test. I'll try help you with that.

patriczek2811 commented 7 years ago

Thanks for feedback, my dear friend,

I'll try to do all of your requirements as soon as possible.

How about design and features like charts, sortable tables and dateTime pickers? Could it be like this?

OndrejVicar commented 7 years ago

Yea. It looks great :) good work thanks

patriczek2811 commented 7 years ago

Don't thank me dear :) It was my pleasure.

Ok, now, I made some tests about speed of pages. I tried two method of speed up and results are committed in branch front-end-speedup.

This linked table describes measured load times of templates in mili-seconds. I used Windows and also Linux based virtual-server to run Hodoor and to do that tests.

Please keep on mind that loadtime of swipes.html is too long because of huge data amount to render. I used database /w 780 swipes. And in swipes.html it loads all of them. The time on my computer is about 30 seconds! That's bad... I know.

In branch/front-end-speedup was applied method 1. - removed unused scripts, PaceLoader.js was turned off, we can turn it on and show user pages after all scripts are done. It's up to you, as you will.

Thanks, enjoy Easter holidays :)

OndrejVicar commented 7 years ago

Thanks, nice work :) pls merge front-end-speedup to frontend-design so it is part of this PR. Do it like this:

git checkout frontend-design
git merge front-end-speedup
git push

Always push to same branch, if you are requested for changes in PR, because github automatically updates PR with new commits and reviewer can notice it.

patriczek2811 commented 7 years ago

Thanks, it worked. I also deleted old branch front-end-speedup. We don't need to work on it anymore. Frontend-design is now up to date.