search

hodooor / Hodoor

Server side for Hodoor - Casual attendance system
GNU General Public License v3.0
8 stars 6 forks source link

Issue 25# and firefox driver changed to chrome driver #61

Closed Tomik292 closed 7 years ago

OndrejVicar commented 7 years ago

Good job here :)

Got few things. 1) I see you are using PyCharm. You should evaluate which files should be commited to git version control (files in .idea). More info is on jetbrains page https://www.jetbrains.com/help/pycharm/2017.1/managing-projects-under-version-control.html. You should probably ignore whole .idea folder in .gitignorefor now because you will be not using pycharm for testing and so on.

2) Path for chrome driver has to be hardcoded like that? I'm not sure, if it will be available in all Linux distributions on that path and it will not definitly work on Windows (but i don't think we should be able to develop on Windows]. If you installed it with pip, you should add dependency to requirements.txt file. If you installed it as system package with apt-get, you should add it to README.md - Everyone has to be able to reproduce your build anytime.

OndrejVicar commented 7 years ago

@Tomik292

  1. link to chrome driver installation instructions does not work
  2. .idea was not removed
  3. Dunno what is commit 4c08190 - probably some mistake - try to fix it, delete it or revert or something like that