search

holdex / pr-time-tracker

https://autoinvoice-theta.vercel.app
0 stars 3 forks source link

Problem: can't submit PR cost #245

Closed markholdex closed 6 months ago

markholdex commented 6 months ago

image

georgeciubotaru commented 6 months ago

@markholdex image

Regarding the other parts:

The problem remains and should be handled by our application, but following the above rules will help to avoid most of them. A similar problem is here at #244

markholdex commented 6 months ago

@georgeciubotaru got it. Thanks for the explanations. Lewis submitted the time because I was able to get the direct link. Otherwise, it would not appear in his interface in PR Time Tracker.

zolotokrylin commented 6 months ago

Guys, sorry, I am not 100% sure I understood what's the reason of the problem and how to overcome it. May be if you explain why it didn't work for Lewis I will get it. Sorry, and thanks 🙏

zolotokrylin commented 6 months ago

Same here: https://github.com/truflation/website/pull/117 I can't see how I can submit the cost and I can't see where is this check if the developer has submitted the cost :(

georgeciubotaru commented 6 months ago

@zolotokrylin Regarding truflation/website/pull/117

image

Some actions need to be followed in Github as the app operates specifically on these actions.

  1. Approve PR before merging (to count as a contributor)
  2. After any change requested during 1 review, to re-request review as the reviewers list comes empty in the event

I know this is not an excuse for the app to not work, but these things should become rules and practices for all of us, same as we have with Problems and PRs`.

markholdex commented 6 months ago

@georgeciubotaru strange. In your screenshot, I can see the hours submitted but If I go an open the PR myself, I can't see them. Where do you click to see them in the PR?

georgeciubotaru commented 6 months ago

@markholdex Just hover over the first commit (where the green check is displayed)

markholdex commented 6 months ago

Hovering didn't work. Clicking did. But the inconsistency of it is still annoying as you understand.

zolotokrylin commented 6 months ago

The only reason why it was submitted, is because I went directly to our PR tracker app and found that PR in the list and submitted the time. I did it to check if we actually capture PRs. So the PR was captured, but it was not displayed in the check (where it was expected to be displayed) and also there was no message in PR saying "you must submit PR".

It is extremely confusing... even for me, who is the advocate of this tool. We can't put it as a rule as it is not KISS, but very complex and confusing... the rules should make sense for business, and we can't make 1000000 rules as I mentioned yesterday during the call. We should have a limited amount of rules, so we can easily track them and coach people. We can't coach people when we have thousands of little rules (it is a nightmare).

What would be the plan here? Let's describe the Specs of how this application is supposed to work from a business perspective.

markholdex commented 6 months ago

@georgeciubotaru do you still want to implement something here to fix this problem?

georgeciubotaru commented 6 months ago

@markholdex I've already implemented 3 things

The issue is still open as I'm still checking if all good

georgeciubotaru commented 6 months ago

@markholdex, @zolotokrylin

As the implemented changes are working, you can open another issue if the problem continues.