feat: filter some events to not trigger fix pr check run

teodorus-nathaniel commented 1 week ago

Resolves #324

Filtered events:

PR body edit
draft PR

Summary by CodeRabbit

New Features
- Enhanced logic for handling fix pull requests, improving the conditions under which checks are run or deleted.
- Introduced clearer event processing for pull requests based on title changes and event types.
- Improved logging for task management, enhancing traceability in error handling and task execution.
Bug Fixes
- Improved handling of draft pull requests, ensuring they are skipped during processing.
Documentation
- Updated logging for better clarity on skipped events and organization status.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
autoinvoice	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 19, 2024 9:01am

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the runPrFixCheckRun function in fix-pr.ts, focusing on the logic for executing or deleting fix pull request checks. A new boolean variable, isPullRequestEvent, is introduced to identify pull request events. The logic now utilizes shouldRunFixPrCheck and shouldDeleteFixPrCheck flags to streamline decision-making based on title changes and event types. Additionally, the function includes handling for draft pull requests and logs specific messages for skipped events. Changes to the deleteComment, getPreviousComment, and getPullRequestByIssue functions in utils.ts enhance error handling and logging.

Changes

File	Change Summary
src/lib/server/trigger-dev/fix-pr.ts	Updated logic in `runPrFixCheckRun` to use flags for determining when to run/delete checks. Added handling for draft PRs and improved logging.
src/lib/server/trigger-dev/utils.ts	Enhanced error handling and logging in `deleteComment`, `getPreviousComment`, and `getPullRequestByIssue` functions.

Assessment against linked issues

Objective	Addressed	Explanation
Fix PR check runs on draft PR (#324)	✅
PR body edits should not affect Fix PR flow (#324)	✅

Possibly related PRs

#293: The changes in createJob for handling previous comments in issues may relate to the logic of managing comments in the runPrFixCheckRun function, which also deals with comment handling based on pull request events.
#317: The introduction of the runPrFixCheckRun function in the issues-comment.ts file indicates a direct connection to the main PR's modifications, as it enhances the functionality related to pull request handling.
#319: The modifications in check-run.ts regarding the management of check runs and the handling of events related to submissions and bug reports are closely related to the changes made in the main PR, particularly in the context of managing pull request titles and associated checks.
#322: The updates to the event specifications for GitHub issue comments and the handling of bug report events are relevant to the main PR's focus on managing pull request events and comments, particularly in the context of bug reports.

Suggested reviewers

georgeciubotaru

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

pr-time-tracker[bot] commented 1 week ago

@teodorus-nathaniel please use git blame and specify the link to the commit link that has introduced this bug. Send the following message in this PR: @pr-time-tracker bug commit [link] && bug author @name

teodorus-nathaniel commented 1 week ago

@georgeciubotaru added the naming conflict problem solution in this PR

holdex / pr-time-tracker