Hotfix/add matariki nz ph

holidays / definitions

Holiday definition files. You deserve a holiday!

Other

112 stars 136 forks source link

Hotfix/add matariki nz ph #209

Closed benaitcheson closed 2 years ago

benaitcheson commented 2 years ago

!no-server

Description of changes

Added Matariki Public Holiday. Link to government website here.

Notes for code reviewers

There was no way of writing a method for these days so they were hard coded into the file.

bagp1 commented 2 years ago

@benaitcheson Why was this closed?

benaitcheson commented 2 years ago

Accidentally tried merging into this repo instead of our forked repo. @bagp1

Github keeps defaulting to this one.

bagp1 commented 2 years ago

Oh that explains the diff haha.

If your repo is similar to this one, I don't think your change is going to return you any Holidays for July. You're meant to use month 0 for things like Easter and Matariki which can potentially land on more than one month.

Here's what I came up with https://github.com/holidays/definitions/pull/224/files

benaitcheson commented 2 years ago

That's amazing. Thank you so much!