search

holidays / definitions

Holiday definition files. You deserve a holiday!
Other
112 stars 136 forks source link

bugfix: Juneteenth Saturday behavior #221

Closed jibarra closed 2 years ago

jibarra commented 2 years ago

According to the Federal Reserve website, bank holidays that fall on a Saturday are still observed on that Saturday. Bank holidays that fall on a Sunday are observed the following Monday. This updates the rules for Juneteenth's observed date to follow these rules. It also lines up with the rules for all the other federal reserve holidays in this definition.

I've updated tests for this new behavior and added another test to ensure the Sunday case is handled.

jibarra commented 2 years ago

👋 @ppeble and @ttwo32 - I think this is good to be reviewed. Could I get eyes on this change?

Please let me know if I can direct this to other folks too.

ttwo32 commented 2 years ago

@jibarra I'm really sorry for my late response. Maybe this PR is the same as #214. （Because I neglected maintenance. sorry💦 ）

jibarra commented 2 years ago

Yup #214 looks the same. I'll close this out.