search

holidays / definitions

Holiday definition files. You deserve a holiday!
Other
112 stars 136 forks source link

Dynamic calculation for AU QLD Ekka holiday #228

Closed antonivanopoulos closed 2 years ago

antonivanopoulos commented 2 years ago

We had an issue recently where the date 2022-08-17 was being recognised as the day for the Brisbane region-specific holiday of Ekka in Australia. However, the holiday had already occurred the week prior.

Having a poke around, I've seen that the holiday is currently using a static value for the third-last Wednesday of August:

8:
  - name: Ekka
    regions: [au_qld_brisbane]
    week: -3
    wday: 3

However, as defined on the QLD public holidays page:

The Royal National Agricultural (RNA) Show Day (Brisbane only) is held on the Wednesday during the RNA Show period. The RNA Show commences on the first Friday in August, unless the first Friday is prior to 5 August, then it commences on the second Friday of August.