search

holidays / definitions

Holiday definition files. You deserve a holiday!
Other
112 stars 136 forks source link

Add QEII Memorial Bank Holiday #235

Closed hlascelles closed 2 years ago

hlascelles commented 2 years ago

With tests.

frankieroberto commented 2 years ago

@ttwo32 could we get this merged asap? 🙏 The extra bank holiday was announced only a week before the event, and so quite a few downstream services need this update as soon as possible.

WorkSutton commented 2 years ago

Is there any chance this will be merged in today? My project uses the holidays gem and we have to decide by COP (close of play) today if we are to add this ourselves, in the likelihood that this is not merged today. Apologies for the pressure, I would merge if I had capabilities, but for me its merging is blocked as I am not a committer/maintainer on the project! Thanks in advance

ppeble commented 2 years ago

Yes, I will take a look at it this morning. I apologize for the silence, to be quite honest my personal life has taken up almost all of my attention for the past few months (for good reasons, my family is expecting another child in less than a month!). I understand the necessity of the speed of this so I will look before I start work.

frankieroberto commented 2 years ago

Yes, I will take a look at it this morning. I apologize for the silence, to be quite honest my personal life has taken up almost all of my attention for the past few months (for good reasons, my family is expecting another child in less than a month!). I understand the necessity of the speed of this so I will look before I start work.

Thank you (and congratulations)! Usually we get a bit more notice for a bank holiday...

ppeble commented 2 years ago

Okay! I released 8.6.0 of the gem with all the latest definitions. Please give it a shot and if you notice any issues open something here and I will do my best to react ASAP.

WorkSutton commented 2 years ago

@ppeble a big thank you and congratulations on your good news. Code delivery is so much simpler! 😄