Remove dead code from the kernel extension

homalg-project / CddInterface

Gap Interface to Cdd

https://homalg-project.github.io/CddInterface

Other

1 stars 5 forks source link

Remove dead code from the kernel extension #4

Closed fingolfin closed 5 years ago

fingolfin commented 5 years ago

Removed code is bug free ... :-). And using static helps discover unused code, and also enables a few extra compiler optimizations.

The next step should be remove all those ugly global variables being used to pass around data...

fingolfin commented 5 years ago

I also have a PR ready which removes the remaining global variables, but I've already opened a bunch of other PRs; once you handled them all (by merging or rejecting), I can rebase that other code, and submit a final PR. That then also seems to stop CddInterface from segfaulting in the test suite (which it currently always does for me), though I have not yet analyzed which of my changes fixes the issues (if the issue is indeed fixed, and not just covered up).

kamalsaleh commented 5 years ago

Thank you Max. If you knew the reason that caused the segfault, please let me know :)