homchom / recode

a utility-focused fabric mod to make DiamondFire development more fun
GNU Lesser General Public License v3.0
27 stars 28 forks source link

implement send-to-plot with "pls join" protocol #42

Closed o7Moon closed 1 year ago

o7Moon commented 1 year ago

pls join is a simple protocol for client side send-to-plot. There is currently a client implementation that uses dfscript, and it works, however the protocol would benefit from having a more widely used implementation, and I think including it in recode would be the perfect way to acheive that.

It would be very intrusive if automatic joining was enabled by default, so I think there should be (at minimum) these three modes:

Additionally there should be a configurable cooldown to prevent abuse.

I plan on implementing this myself, is this something that would get merged?

MrSam7K commented 1 year ago

I don't think it's a good idea, also imo you should've posted this to discord for more feedback.

homchom commented 1 year ago

In general I'm very opposed to features like this because I don't want playing a plot to "require" recode (or any mod) for an optimal playing experience. We're probably going to come up with a more polished and hidden protocol later, but in any case it will have a prompt, which we do not yet have the infrastructure to code easily.

o7Moon commented 1 year ago

I don't want playing a plot to "require" recode (or any mod) for an optimal playing experience. We're probably going to come up with a more polished and hidden protocol later

I've tried to design the protocol specifically to address this issue, the message tells the player what to do in the case that they don't have any kind of mod.

Manually typing the command will never be as efficient as having a mod do it automatically, but I don't think that it makes sense to deny a convenience feature because of the vanilla client not having the same convenience.