home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.82k stars 30.08k forks source link

Sun weather condition at night #102466

Closed Sboshoff76 closed 8 months ago

Sboshoff76 commented 11 months ago

The problem

Partly cloudy at night has a sun icon image

What version of Home Assistant Core has the issue?

core-2023.10.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

tomorrowio

Link to integration documentation on our website

https://www.home-assistant.io/integrations/tomorrowio

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 11 months ago

Hey there @raman325, @lymanepp, mind taking a look at this issue as it has been labeled with an integration (tomorrowio) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `tomorrowio` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign tomorrowio` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


tomorrowio documentation tomorrowio source (message by IssueLinks)

lymanepp commented 11 months ago

This appears to be a bug in the HA front-end. It defines a function to get the weather icon from the state and nightTime boolean.

export const weatherIcon = (state?: string, nightTime?: boolean): string =>
  !state
    ? undefined
    : nightTime && state === "partlycloudy"
    ? mdiWeatherNightPartlyCloudy
    : weatherIcons[state];

But the nightTime argument is not present when it's called.

switch (domain) {
  // removed other cases for clarity
  case "weather":
    return weatherIcon(stateObj?.state);
}

Feel free to reference this comment when you submit a new issue at https://github.com/home-assistant/frontend/issues/new/choose

issue-triage-workflows[bot] commented 8 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.