search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
74.09k stars 31.1k forks source link

Starlink has poor timeout handling #112879

Open boswelja opened 8 months ago

boswelja commented 8 months ago

The problem

Instead of using magic number 4 everywhere, we should make a constant DEFAULT_TIMEOUT or something, but that could happen in a separate PR. Also, it doesn't seem like anything is catching the timeout errors, which means that users will see stack traces if it happens. The timeout errors should be caught and nicely logged IMO. Again, that can happen in a separate PR since it also affects already existing code. Thanks @emontnemery

What version of Home Assistant Core has the issue?

core-2024.3.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Starlink

Link to integration documentation on our website

https://www.home-assistant.io/integrations/starlink/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 8 months ago

starlink documentation starlink source

joostlek commented 8 months ago

You don't need to create an issue before creating a PR FYI

boswelja commented 8 months ago

I know, I don't plan on creating a PR any time soon so tracking it is probably a good idea 🙂

joostlek commented 8 months ago

Aah, because I also saw a Starlink PR updated at the same time so i thought this issue was created for that PR

issue-triage-workflows[bot] commented 5 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

boswelja commented 5 months ago

This has not been resolved, I'm just not motivated

issue-triage-workflows[bot] commented 2 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

boswelja commented 2 months ago

This has not been resolved, I'm just not motivated