home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.3k stars 30.61k forks source link

Matter: `Identify` cluster button should be shown only if IdentifyType != 0 #128020

Open hacker-cb opened 3 weeks ago

hacker-cb commented 3 weeks ago

The problem

Currently Matter integration create lot of button for each endpoint, even if IdentifyTypeEnum=None. As I result, there is a lot of unusable buttons (One for each endpoint):

image

There is no reason to display identify button for endpoints when it has IdentifyTypeEnum atrribute set to None.

Matter refs:

image image

What version of Home Assistant Core has the issue?

core-2024.10.0

Integration causing the issue

matter

Link to integration documentation on our website

https://www.home-assistant.io/integrations/matter/

home-assistant[bot] commented 3 weeks ago

Hey there @home-assistant/matter, mind taking a look at this issue as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `matter` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign matter` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


matter documentation matter source (message by IssueLinks)

marcelveldt commented 2 weeks ago

Yeah, this is a small bug/oversight in the discovery schema. Will be fixed soon.