home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.34k stars 30.64k forks source link

Fix flaky camera test #129576

Closed epenet closed 2 days ago

epenet commented 3 days ago

Breaking change

Proposed change

Fix flaky camera test, which compares unsorted lists:

Differing items:
{'frontend_stream_types': ['hls', 'web_rtc']} != {'frontend_stream_types': [<StreamType.WEB_RTC: 'web_rtc'>, <StreamType.HLS: 'hls'>]}

As spotted in: https://github.com/home-assistant/core/actions/runs/11610672146/job/32330782557

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 3 days ago

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (camera) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `camera` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign camera` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
epenet commented 3 days ago

Not sure if it should be added to beta...