home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
74.08k stars 31.09k forks source link

Add index to linkplay.play_preset #130661

Open dnikles opened 2 weeks ago

dnikles commented 2 weeks ago

The problem

On my devices, the MCUKeyShortClick command will take both a preset number and an index. For example, I can curl -k https://192.168.2.176/httpapi.asp?command=MCUKeyShortClick:6:2 and it will play preset 6, track 2. If I call it without the :2, it resumes the playlist from the last point it was stopped. I'm unable to pass "6:2" as it requires a number. Maybe index can be an additional option to send?

What version of Home Assistant Core has the issue?

core-2024.10.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

linkplay

Link to integration documentation on our website

https://www.home-assistant.io/integrations/linkplay

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 2 weeks ago

Hey there @velleman, mind taking a look at this issue as it has been labeled with an integration (linkplay) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `linkplay` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign linkplay` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


linkplay documentation linkplay source (message by IssueLinks)

silamon commented 2 weeks ago

What devices are supposed to support this? I can't find any documentation about it. (How did you found out?)

If the parameter isn't supported on all devices, it should only be shown on those devices know to support it.

dnikles commented 2 weeks ago

Wiim supports it. Unfortunately wiim and good API documentation do not seem to go hand in hand. I found out by just trying it. I don't know if anything else supports it. Try it out! I don't know the likelihood that others support it but I wouldn't be surprised if it's not the only one.

On Fri, Nov 15, 2024 at 12:17 PM Simon Lamon @.***> wrote:

What devices are supposed to support this? I can't find any documentation about it. (How did you found out?)

If the parameter isn't supported on all devices, it should only be shown on those devices know to support it.

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/130661#issuecomment-2479474814, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEHXEDYHZVOWDNFMY2YQFPL2AYUB5AVCNFSM6AAAAABRZ4MWIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZZGQ3TIOBRGQ . You are receiving this because you authored the thread.Message ID: @.***>