search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.89k stars 30.96k forks source link

zwavejs integration "configure device" option doesnt work anymore starting with 2022.4.0 #69497

Closed fgonza2 closed 2 years ago

fgonza2 commented 2 years ago

The problem

When you go into the zwavejs, click on a device. then "configure device". it doesnt load, stays there forever. THis started with 2022.4.0

What version of Home Assistant Core has the issue?

2022.4.0

What was the last working version of Home Assistant Core?

2022.3.8

What type of installation are you running?

Home Assistant Container

Integration causing the issue

zwavejs

Link to integration documentation on our website

https://www.home-assistant.io/integrations/zwave_js

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

probot-home-assistant[bot] commented 2 years ago

Hey there @home-assistant/z-wave, mind taking a look at this issue as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

zwave_js documentation zwave_js source (message by IssueLinks)

elchininet commented 2 years ago

@fgonza2, Check that you have followed all the steps in the breaking changes:

With this release, you will need to update your zwave-js-server instance. If you use the zwave_js add-on, you need to have at least version 0.1.54. If you use the Z-Wave JS 2 MQTT add-on, you need to have at least version 0.35.2. If you use the zwavejs2mqtt Docker container, you need to have at least version 6.5.2. If you run your own Docker container, or some other installation method, you will need to update your zwave-js-server instance to at least 1.15.0.

kpine commented 2 years ago

The browser debugger is showing the following error. Looks like comment metadata is not being provided.

Uncaught (in promise) TypeError: this._nodeMetadata.comments is undefined
    value zwave_js-node-config.ts:182
    update app.b39ee8d3.js:1248
    performUpdate app.b39ee8d3.js:1248
    scheduleUpdate app.b39ee8d3.js:1248
    _$EC app.b39ee8d3.js:1248
    requestUpdate app.b39ee8d3.js:1248
    set app.b39ee8d3.js:1248
    value zwave_js-node-config.ts:317
    value ha-config-section.ts:6
    _$AE app.b39ee8d3.js:1248
    performUpdate app.b39ee8d3.js:1248
    scheduleUpdate app.b39ee8d3.js:1248
    _$EC app.b39ee8d3.js:1248
    requestUpdate app.b39ee8d3.js:1248
    set app.b39ee8d3.js:1248
    value ha-config-section.ts:6
    r app.b39ee8d3.js:1248
    l app.b39ee8d3.js:1248
    promise callback*l app.b39ee8d3.js:1248
    c app.b39ee8d3.js:1248
    subscribe app.b39ee8d3.js:1248
    o app.b39ee8d3.js:1248
    f ha-textfield.ts:7
    value ha-config-section.ts:6
    value ha-textfield.ts:7
    value ha-textfield.ts:7
    value ha-config-section.ts:6
    connectedCallback typography.js:181
    value hass-loading-screen.ts:11
    _currentLoadProm hass-loading-screen.ts:11
    promise callback*value hass-loading-screen.ts:11
    performUpdate app.b39ee8d3.js:1248
    scheduleUpdate app.b39ee8d3.js:1248
    _$EC app.b39ee8d3.js:1248
    requestUpdate app.b39ee8d3.js:1248
    o app.b39ee8d3.js:1248
    b app.b39ee8d3.js:1248
    r hass-loading-screen.ts:11
    F c7619eab.js:1
    E typography.js:181
    t typography.js:181
    value hass-loading-screen.ts:11
    value hass-loading-screen.ts:11
    value hass-loading-screen.ts:11
    performUpdate app.b39ee8d3.js:1248
    scheduleUpdate app.b39ee8d3.js:1248
    _$EC app.b39ee8d3.js:1248
zwave_js-node-config.ts:182
    _$EC app.b39ee8d3.js:1248
    AsyncFunctionThrow self-hosted:704
    (Async: async)
    requestUpdate app.b39ee8d3.js:1248
    set app.b39ee8d3.js:1248
    value c7619eab.js:1
    value hass-loading-screen.ts:11
    performUpdate app.b39ee8d3.js:1248
    scheduleUpdate app.b39ee8d3.js:1248
    _$EC app.b39ee8d3.js:1248
    AsyncFunctionNext self-hosted:700
    (Async: async)
    requestUpdate app.b39ee8d3.js:1248
    set app.b39ee8d3.js:1248
    value 3cd75f3a.js:1
    value hass-loading-screen.ts:11
    performUpdate app.b39ee8d3.js:1248
    scheduleUpdate app.b39ee8d3.js:1248
    _$EC app.b39ee8d3.js:1248
    AsyncFunctionNext self-hosted:700
    (Async: async)
    requestUpdate app.b39ee8d3.js:1248
    set app.b39ee8d3.js:1248
    value app-drawer-layout.js:189
    value hass-loading-screen.ts:11
    performUpdate app.b39ee8d3.js:1248
    scheduleUpdate app.b39ee8d3.js:1248
    _$EC app.b39ee8d3.js:1248
    AsyncFunctionNext self-hosted:700
    (Async: async)
    requestUpdate app.b39ee8d3.js:1248
    set app.b39ee8d3.js:1248
    k app.b39ee8d3.js:1248
    _$AI app.b39ee8d3.js:1248
    m app.b39ee8d3.js:1248
    T app.b39ee8d3.js:1248
    _$AI app.b39ee8d3.js:1248
    S app.b39ee8d3.js:1248
    update app.b39ee8d3.js:1248
    performUpdate app.b39ee8d3.js:1248
    scheduleUpdate app.b39ee8d3.js:1248
    _$EC app.b39ee8d3.js:1248
    AsyncFunctionNext self-hosted:700
    (Async: async)
    requestUpdate app.b39ee8d3.js:1248
raman325 commented 2 years ago

comments should always be in the object though, at worst case as an empty list. With that being said, I can reproduce this so I will look into it

raman325 commented 2 years ago

@kpine identified that https://github.com/home-assistant/core/pull/67210 didn't make it into the release which would cause this issue. We will included it in the next patch release

fgonza2 commented 2 years ago

@fgonza2, Check that you have followed all the steps in the breaking changes:

With this release, you will need to update your zwave-js-server instance. If you use the zwave_js add-on, you need to have at least version 0.1.54. If you use the Z-Wave JS 2 MQTT add-on, you need to have at least version 0.35.2. If you use the zwavejs2mqtt Docker container, you need to have at least version 6.5.2. If you run your own Docker container, or some other installation method, you will need to update your zwave-js-server instance to at least 1.15.0.

Yes i am using zwave2mqtt container 6.7.0, so i am complying with the requirements. (>6.5.2)

fgonza2 commented 2 years ago

@kpine identified that #67210 didn't make it into the release which would cause this issue. We will included it in the next patch release

great. hopefully it makes it into the next release patch

GaTechThomas commented 2 years ago

Does a workaround exist in the meantime?

robertgetch commented 2 years ago

Does a workaround exist in the meantime?

The best workaround I can think of would be to use call_service to set or change the parameter if you know which one it is.

fgonza2 commented 2 years ago

i am going directly to the zwavejs2mqtt GUI on the meantime

fgonza2 commented 2 years ago

confirmed fixed on 2022.4.1