search

homebridge / plugins

Information and resources for Homebridge plugins.
https://homebridge.io/w/Verified-Plugins
GNU General Public License v3.0
368 stars 17 forks source link

homebridge-spotify-speaker #525

Closed joeyhage closed 1 year ago

joeyhage commented 1 year ago

Link To GitHub Repo

https://github.com/joeyhage/homebridge-spotify-speaker

Link To NPM Package

https://www.npmjs.com/package/homebridge-spotify-speaker

github-actions[bot] commented 1 year ago

:white_check_mark: Pre-checks completed successfully.

joeyhage commented 1 year ago

I forked the original homebridge-spotify-speaker because it is no longer being maintained. See https://github.com/poblouin/homebridge-spotify-speaker/commit/66ba4dae12705ac09ab421abad2a149686c227d4#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R12

bwp91 commented 1 year ago

Just seeing if it is possible for you to be able to take over the original repo + npm package to cause least disruption to existing users who have this plugin installed

https://github.com/poblouin/homebridge-spotify-speaker/issues/27

joeyhage commented 1 year ago

@bwp91 sure, that’s fine with me.

How would that work with npm publishing? Would the original repo stay the same and a GitHub action need to be created so poblouin doesn’t need to share an npm token with me?

bwp91 commented 1 year ago

The GitHub repo and NPM package would be transferred to us then we can transfer it to you. You can choose whether to work from your existing GitHub repo or publish your updates to the older one. You'd be able to publish to the npm repo just like you do now.

joeyhage commented 1 year ago

Great! Thanks, @bwp91. Sorry for my ignorance on that - I haven’t done a repo/npm transfer before. Let me know if you need anything from me to complete the transfer.

bwp91 commented 1 year ago

We can start with the github repo. Please create an issue here, there is an option to request a repo.

https://github.com/homebridge/unmaintained-plugins/issues

You may notice the repo isn’t listed on the readme yet, this is simply because i haven’t added it there (haven’t bothered!)

joeyhage commented 1 year ago

✔️

joeyhage commented 1 year ago

I updated the npm package above to https://www.npmjs.com/package/homebridge-spotify-speaker since that is the one that will be maintained going forward and should be verified

joeyhage commented 1 year ago

@bwp91 also, once we get the ownership changes figured out and the new plug-in name verified, don’t let me forget to request a verified plugin channel in Discord. Thanks!

bwp91 commented 1 year ago

i transferred the repo to you a few days ago. once you are ready for the (new) plugin to be verified, please reply on here with a comment just saying /check and can look into verifying!

joeyhage commented 1 year ago

I’m ready! /check

joeyhage commented 1 year ago

/check

github-actions[bot] commented 1 year ago

:white_check_mark: Pre-checks completed successfully.

bwp91 commented 1 year ago

looks good to me, the github labels aren't working for me at the moment so will post the standard response here!

will add homebridge-spotify-speaker to the verified list and remove the old one.

Congratulations! Your plugin has been verified.

You can now add the Verified by Homebridge badge to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a :heart: Donate button on it's tile in the Homebridge UI. See https://github.com/oznu/homebridge-config-ui-x/wiki/Developers:-Donation-Links for instructions.

Thank you for your contribution to the Homebridge Community. https://homebridge.io