homebridge-evohome

[luc-ass]

Plugin Details This plugin integrates Honeywell Evohome (https://getconnected.honeywellhome.com/de/thermostate/evohome) into Homebridge. It has been running smoothly for some years now. At this point I feel that it is ready for prime time. I added support for config-ui-x (config.schema.json) and created my first release.

• Plugin Name: homebridge-evohome
• Link To GitHub Repo: https://github.com/luc-ass/homebridge-evohome
• Link To NPM Package: https://www.npmjs.com/package/homebridge-evohome

Thank you for all your great work!

[github-actions[bot]]

:white_check_mark: Pre-checks completed successfully.

[donavanbecker]

• [x] - The plugin must successfully install.
• [x] - The plugin must implement the Homebridge Plugin Settings GUI.
• [x] - The plugin must not start unless it is configured.
• [x] - The plugin must not execute post-install scripts that modify the user's system in any way.
• [x] - The plugin must not contain any analytics or calls that enable you to track the user.
• [ ] - The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
• [x] - The plugin must be published to npm and the source code available on GitHub.
• [x] - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v10 and v12.
• [x] - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
• [x] - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

---

The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors. If receive invalid login or grant, plugin stops homebridge from running.

Error during Login: invalid_grant

[donavanbecker]

@luc-ass, you need to call callback([]) in these errors to prevent homebridge from blocking. https://github.com/luc-ass/homebridge-evohome/blob/master/index.js#L176-L190

[luc-ass]

Just so I can get this right: you did not enter any credentials and homebridge stopped because of this?

[donavanbecker]

@luc-ass I added incorrect credentials and it stopped Homebridge from running. The plugin must log it’s own. And must keep Homebridge running even if wrong credentials are inputted.

[luc-ass]

Thank you so much for your input! I fixed the crashing problems if no or wrong credentials are set up.

I don’t quite understand what “must log it’s own” is supposed to mean. Could you elaborate? Am I supposed to create a separate log file?

[luc-ass]

@donavanbecker I published a new version to npm (v0.7.1). Would you have a look at it?

[donavanbecker]

I don’t quite understand what “must log it’s own” is supposed to mean. Could you elaborate? Am I supposed to create a separate log file?

Sorry, my wording was wrong. what you changed was exactly what I was meaning. Everything looks good. I will get it on the verified list as soon as I can.

[donavanbecker]

/check

[github-actions[bot]]

:white_check_mark: Pre-checks completed successfully.

[donavanbecker]

[luc-ass]

@donavanbecker we have run into problems because of the empty callback. This causes the accessories to be removed if the server doesn't respond (for example because of maintenance). Is there an alternative to callback([]), that prevents the plugin from blocking and marks existing accessories as "Not responding"? So far my searches didn't result in a solution...