hongquan / CoBang

A QR code scanner desktop app for Linux
GNU General Public License v3.0
240 stars 27 forks source link

Translation related patches #82

Closed ghost closed 5 months ago

ghost commented 6 months ago
hongquan commented 5 months ago

Thank you.

hongquan commented 5 months ago

Hi @sabriunal now I try to build Deb package with your change, and get this error:

[1/7] msgfmt ../po/it.po -o po/it/LC_MESSAGES/cobang.mo
[2/7] msgfmt ../po/nl.po -o po/nl/LC_MESSAGES/cobang.mo
[3/7] msgfmt ../po/fr.po -o po/fr/LC_MESSAGES/cobang.mo
[4/7] msgfmt ../po/tr.po -o po/tr/LC_MESSAGES/cobang.mo
[5/7] msgfmt ../po/vi.po -o po/vi/LC_MESSAGES/cobang.mo
[6/7] /usr/bin/meson --internal msgfmthelper ../data/vn.hoabinh.quan.CoBang.appdata.xml.in data/vn.hoabinh.quan.CoBang.appdata.xml xml ../data/../po
FAILED: data/vn.hoabinh.quan.CoBang.appdata.xml 
/usr/bin/meson --internal msgfmthelper ../data/vn.hoabinh.quan.CoBang.appdata.xml.in data/vn.hoabinh.quan.CoBang.appdata.xml xml ../data/../po
msgfmt: cannot read ../data/vn.hoabinh.quan.CoBang.appdata.xml.in: Premature end of data in tag component line 3

msgfmt: cannot read ../data/vn.hoabinh.quan.CoBang.appdata.xml.in: Premature end of data in tag component line 3

msgfmt: cannot locate ITS rules for ../data/vn.hoabinh.quan.CoBang.appdata.xml.in
[7/7] /usr/bin/meson --internal msgfmthelper ../data/vn.hoabinh.quan.CoBang.desktop.in data/vn.hoabinh.quan.CoBang.desktop desktop ../data/../po
ninja: build stopped: subcommand failed.
dh_auto_build: error: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 ninja -j12 -v returned exit code 1
make: *** [debian/rules:5: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
hongquan commented 5 months ago

Seems to need appstream as build dependency.

ghost commented 5 months ago

I've tested with flatpak and you need "appstreamcli" due to the following changes. I can revert that part if you want.

https://github.com/hongquan/CoBang/pull/82/files#diff-ee0d750477d547a86d51c7a857402ca2dda7aed3d3f130978183d81ef204f9c2R37-R41

hongquan commented 5 months ago

Let's try to build with your change first. I install appstreamcli on Ubuntu but it still fails to locate ITS rules.

hongquan commented 5 months ago

I guess we need to rename the appdata file to metainfo.

ghost commented 5 months ago

okay.

ghost commented 5 months ago

I guess we need to rename the appdata file to metainfo.

I spotted the problem and fixed via https://github.com/hongquan/CoBang/pull/86/files