[oauth-providers] Problem with GitHub provider from version 0.5.0

honojs / middleware

monorepo for Hono third-party middleware/helpers/wrappers

https://hono.dev

478 stars 173 forks source link

[oauth-providers] Problem with GitHub provider from version 0.5.0 #729

Open geommr opened 2 months ago

geommr commented 2 months ago

starting from version 0.5.0 the redirect to callback no longer works on OAuth apps (returns HTTP 400 with body "Not found"). the getEmail refactor removes the this.oauthApp check, which is where I suspect the problem is -- v0.4.0 was working as expected.

Tested both on Hono v4.5.11.

I can open a PR if someone confirms this, repo can be found here for testing.

yusukebe commented 2 months ago

Hi @geommr !

@monoald Can you handle this?