search

hoonmin / influxdb-collectd-proxy

A very simple proxy between collectd and influxdb.
MIT License
72 stars 26 forks source link

updated proxy.go to include hostname as a column rather than a series pr... #14

Closed cboggs closed 9 years ago

cboggs commented 10 years ago

...efix

@hoonmin - Thanks for writing this proxy! It's much more reliable than some others I've tried.

Would you be interested in this change to include the hostname as a column to each time series, rather than as a prefix to each series?

In my testing, I've found that InfluxDB is more performant when there are fewer time series to manage. Grouping similar metrics into a single series with a distinguishing field (such as hostname) yields better query performance, usually.

So far this change is working locally and handling metrics just fine, but let me know if I did anything you don't like. :-)

hoonmin commented 10 years ago

@cboggs First of all, thank you for your interests and contribution to the proxy :-)

Though I haven't tried to check the query performance of influxdb yet, I totally agree with you. Actually I've added the hostname as a prefix to the metric name to simplify the queries :-) (and to make it similar to collectd's as possible)

I suggest you that it would be much better to make your changes optional because we already have some users. Could you tell me your idea on this?

Thank you!