hooyushing / pe

0 stars 0 forks source link

Creating a doctor person card does not allow for country code #3

Open hooyushing opened 2 weeks ago

hooyushing commented 2 weeks ago

As a medical staff, it is likely that I have doctors from overseas, who have overseas phone numbers. Without allowing the addition of country code, I am unable to differentiate between individuals from other countries. This will create major inconveniences to medical staff.

Steps to reproduce: 1) Add a doctor with phone number +6587654321 2) There will be a an error message which prevents this from being added.

Expected result: Able to successfully add the doctor Actual result: Unable to add the doctor

Screenshot 2024-11-15 at 4.17.57 PM.png

soc-pe-bot commented 1 week ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Phone numbers do not accept '+' symbol or spaces or hyphens

Screenshot 2024-11-15 at 4.47.46 PM.png Screenshot 2024-11-15 at 4.48.21 PM.png Screenshot 2024-11-15 at 4.47.57 PM.png

Issue: Some contacts that a user may want to enter may have a country code, especially if the contact's phone number is outside of the country that the user is in (ie overseas phone numbers). In such cases, the user would want to record the contact with the phone number including a country code, but that is not allowed. The same can be said of dashes and spaces, which are used in some regions for differentiating different sections of phone numbers (ie area codes) or making phone numbers easier to read.

To replicate, enter any of the following commands: createP n/P3 p/+198765432 e/p2@gmail.com a/8 Kent Ridge Drive 359332 createP n/P3 p/9876 5432 e/p2@gmail.com a/8 Kent Ridge Drive 359332 createP n/P3 p/9876-5432 e/p2@gmail.com a/8 Kent Ridge Drive 359332


[original: nus-cs2103-AY2425S1/pe-interim#1518] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]