contracts: Change underscore policy

hop-protocol / contracts

🐰 Hop Protocol v1 smart contracts

https://hop.exchange

238 stars 98 forks source link

contracts: Change underscore policy #11

Closed cwhinfrey closed 3 years ago

cwhinfrey commented 3 years ago

No underscore

public/external functions
function parameters (except for conflicts with state variables)
local variables
non-private state

Underscore prefix

internal/private functions
function params that conflict conflict with state variables
private state

cwhinfrey commented 3 years ago

@shanefontaine I left the underscore on function params that conflict with non-private state variables. Open to alternatives too though. Uniswap does this in their contracts and I've seen other projects do the same but don't have more examples on hand. Let me know what you think.