Feature/internal audit 3

hop-protocol / contracts

🐰 Hop Protocol v1 smart contracts

https://hop.exchange

238 stars 98 forks source link

Feature/internal audit 3 #25

Closed cwhinfrey closed 3 years ago

cwhinfrey commented 3 years ago

Make hard coded params configurable
- The hard coded values in resolveChallenge are not configurable because I don't think they should change. Open to discussion.
Remove sender from transferId calculation
Rename l2CanonicalTokenIsWeth -> l2CanonicalTokenIsEth
Add TransferRootSet event
Add challengePeriod/timeSlotSize notice
Extend challengeResolutionPeriod to 10 days

cwhinfrey commented 3 years ago

@miguelmota TransferRootSet is added here https://github.com/hop-exchange/contracts/pull/25/commits/ab5451d5e2c79906da6cb9c6c908ad29178c06fa.

The reason for TransferRootSet vs TransferRootBonded is that this event will also be emitted when the TransferRoot is confirmed without being bonded.

I also did a small renaming in that commit amount -> totalAmount.

miguelmota commented 3 years ago

@cwhinfrey changes look great 👍

cwhinfrey commented 3 years ago

@shanefontaine back to you