search

hop-protocol / contracts

🐰 Hop Protocol v1 smart contracts
https://hop.exchange
238 stars 98 forks source link

Add a governance address as an explicit param of the L1 Bridge constructor #45

Closed shanefontaine closed 3 years ago

shanefontaine commented 3 years ago

The L1 bridge currently sets governance = msg.sender. This PR introduces a _governance param that allows you to explicitly define the governance address instead of using msg.sender. I think there are a few reasons to pass in the address explicitly:

  1. More flexibility for deployer
  2. Matches same behavior in L2 bridge
  3. Easier test/script setup