search

hotio / qbittorrent

https://hotio.dev/containers/qbittorrent
GNU General Public License v3.0
116 stars 14 forks source link

[Feature] ENV Variable to change the IP service used #13

Closed Belphemur closed 1 year ago

Belphemur commented 1 year ago

Hello,

I'm having some issues where icanhazip.com don't answer the query (I'm thinking they surely block some VPN provider or have too many requests sent to them).

I've set VPN_IP_CHECK_EXIT=true to not stop the container from starting.

But it'd be nice if I could use a env var to override the service to use (like using ifconfig.co or ifconfig.me or anything else as long as it return the IP in clear text).

I'm suggesting a env var like: VPN_IP_CHECK_SERVICE that could be set to any website.

Btw, if you're interested, I can make a PR for it.

jyggen commented 1 year ago

Seeing this too, most of the time when the container starts icanhazip.com simply returns nothing no matter how long of a delay is added before the IP check.

mrhotio commented 1 year ago

I'd like to not make this a configurable option with a bunch of choices, let's just pick an alternative that works....what about dig -4 TXT +short whoami.cloudflare @1.1.1.1 ch 2>/dev/null | tr -d '"'?

jyggen commented 1 year ago

Works for me!

mrhotio commented 1 year ago

ok, test the new release

jyggen commented 1 year ago

The container exits with the following error message:

[ERROR] ipv6 is disabled, but we got data back in our ipv6 lookup. Exiting...
mrhotio commented 1 year ago

Test new update

Belphemur commented 1 year ago

@mrhotio Thanks for this, dig is definitely more reliable for this !

mrhotio commented 1 year ago

Not for people using mullvad it seems…might still have to tweak this.

Nocifer commented 1 year ago

Hello, any word on this one getting fixed? It really does not like Mullvad, so we've been stuck on release-64adf7b for a while now :)

mrhotio commented 1 year ago

The check is completely removed, so it can’t cause you an issue.