hotosm / fmtm

Field Mapping Tasking Manager - coordinated field mapping.
https://fmtm.hotosm.org/
GNU Affero General Public License v3.0
49 stars 46 forks source link

Add login options to mapper frontend, remove temp login from React frontend #1890

Open spwoodcock opened 1 week ago

spwoodcock commented 1 week ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

NSUWAL123 commented 1 week ago

Adding login on the mapper frontend is completed.

Also, temp login has been removed from the react frontend, but if the user logins via temp login from the mapper frontend and then redirects to the react frontend, the user is also logged on to the react frontend.

So @spwoodcock, as you mentioned changing the cookie name to distinguish between OSM and temp login, I think firstly works on the backend has to be done as the cookie is being set from API call right?

You can review and merge this PR. Then on another PR, I'll do the remaining stuff after we finalize the process of validating osm & temp login on react frontend.

spwoodcock commented 1 week ago

The frontend part of this is solved 💫

It might he worth looking into the backend too, to better separate the temp login option. It should probably be a separate cookie, so that it doesn't work on the management frontend (we need to enforce osm login there)

I can make a follow up issue 👍

spwoodcock commented 1 week ago

Adding login on the mapper frontend is completed.

Also, temp login has been removed from the react frontend, but if the user logins via temp login from the mapper frontend and then redirects to the react frontend, the user is also logged on to the react frontend.

So @spwoodcock, as you mentioned changing the cookie name to distinguish between OSM and temp login, I think firstly works on the backend has to be done as the cookie is being set from API call right?

You can review and merge this PR. Then on another PR, I'll do the remaining stuff after we finalize the process of validating osm & temp login on react frontend.

Haha well timed!!

NSUWAL123 commented 1 week ago

Yeah :laughing:

spwoodcock commented 1 week ago

I made a separate issue for the backend cookie part. Playwright tests are addressed in another PR. This issue is solved once the linked PR is merged.