search

hotosm / tasking-manager

Tasking Manager - The tool to team up for mapping in OpenStreetMap
https://wiki.openstreetmap.org/wiki/Tasking_Manager
BSD 2-Clause "Simplified" License
504 stars 270 forks source link

iD editor upgrade to v2.30.2 #6551

Closed emi420 closed 1 week ago

emi420 commented 3 weeks ago

What type of PR is this?

Related Issue

Fixes https://github.com/hotosm/tasking-manager/issues/5780

Describe this PR

A new version (2.30.2) of the iD Editor was published as a NPM package on hotosm/id

This PR upgrades the package and also adds a configuration line for Webpack to ignore and not parse the iD.min.js file, as it was raising some warnings:

Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
Critical dependency: the request of a dependency is an expression

Search for the keywords to learn more about each warning. 
To ignore, add // eslint-disable-next-line to the line before.

WARNING in ./node_modules/@hotosm/id/dist/iD.min.js 14:40-47
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

WARNING in ./node_modules/@hotosm/id/dist/iD.min.js 17:37-44
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

WARNING in ./node_modules/@hotosm/id/dist/iD.min.js 40022:67-76
Critical dependency: the request of a dependency is an expression

It should be ok as this is a packed and minified file.

Copy static files and imagery patch

I've also divided the commands in package.json for copying static files for both iD and Rapid and removed the patch for the iD imagery as isn't being used anymore.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

royallsilwallz commented 1 week ago

hey @emi420 , we have another issue related to iD upgrade. When I toggle the editor to RapiD and again back to iD, an error occurs. Below is the screenshot -

image

Other findings I have also tried it on different branches (develop). It still shows the same error. So, it is not specific to this (upgrade/iD-editor-2.30.2) branch. Older version (v2.29.0) did not have this error.

Steps to reproduce

cc - @ramyaragupathy @manjitapandey