search

hotosm / tasking-manager

Tasking Manager - The tool to team up for mapping in OpenStreetMap
https://wiki.openstreetmap.org/wiki/Tasking_Manager
BSD 2-Clause "Simplified" License
504 stars 270 forks source link

Logos in about page won't show when running an ad-blocker #702

Closed cgiovando closed 7 years ago

cgiovando commented 7 years ago

In OX 10.11.6 / Chrome 60.0 when an ad-blocker is installed (uBlock Origin v1.13.8), logos in the About page do not show.

Is there a way to embed them similarly to images on the homepage (with simple HTML), so that ad-blockers don't interfere with them?

bgirardot commented 7 years ago

@LindaAlblas The issue seems to be the css class "sponsor-logo" and the EasyList adblocking list.

It looks like "supporters-logo" would work instead for the class name for EasyList at least.

I don't feel comfortable editing classes yet, but I find that blocked text in these files:

app/about/about.html assets/styles/sass/_about.scss assets/styles/css/taskingmanager.css

2017-08-25_15h11_42

LindaAlblas commented 7 years ago

@bgirardot interesting. I'll change the CSS class if you are able to test it then?

bgirardot commented 7 years ago

@LindaAlblas Can do.

Sorry I know it seems simple, but I don't want to mess with stuff I don't understand fully, especially at the moment.

LindaAlblas commented 7 years ago

@bgirardot no worries!

bgirardot commented 7 years ago

@cgiovando this should be fixed now, please let us know if it is not.

deployed to tasks-stage.hotosm.org

you might have to "shift" reload to get everything.

cgiovando commented 7 years ago

:+1: