hotwax / inventory-count

HotWax Commerce Inventory Count
Apache License 2.0
16 stars 66 forks source link

Fixed: both the item change buttons becomes active after changing tab(#442) #491

Closed ymaheshwari1 closed 2 weeks ago

ymaheshwari1 commented 3 weeks ago

Related Issues

442

Short Description and Why It's Useful

As we are using indexOf method for finding the product index, but if we already have a current product set, then in that case the product from state is used for finding the index from the filteredItems list, but as the object do not have a common reference, so in this case it always return -1, resulting in buttons being in wrong state. Improved code to find the selected current product first in the filtered items list and then finding its index, so that it has a common reference.

Screenshots of Visual Changes before/after (If There Are Any)

Before: Both the buttons are active, even when its the first product.

image

Contribution and Currently Important Rules Acceptance