Open dentarg opened 1 month ago
What is the intention, bump required_ruby_version
? Or was this an accident?
We should bump that minimum version, but also, it shouldn't have happened in a tiny version increment. That was a mistake. cc @seanpdoyle
This is a test-only change, and can be converted harm-free.
If 2.6 is the target version, we must add 2.6
and 2.7
to the CI matrix. That can be undone in a follow up release.
While https://github.com/hotwired/turbo-rails/commit/5038ed8fcf046f9dbc03b959280a747ee67a08ae#diff-45934cb0c9b4dc0fdd1aa4e780742e07541f16cb60835e1b1330a56d1b0f18f1R9 is a commit that adds newer 3.0 and 3.1 syntax, reverting those changes alone is not sufficient for executing the test suite for ruby@2.6
and rails@6.1
in CI.
There are a variety of gem version incompatibilities and other syntactical incompatibilities. The gem has not been ruby@2.6
compatible for some time, and there are likely numerous patch and minor versions released since that time.
Cutting a release to solidify working support for 2.6 would be complicated (evidenced by the https://github.com/hotwired/turbo-rails/pull/682's CI failures). The only version of rails that ruby@2.6
is bundle-compatible with is rails@6.1
, and that test suite has an importmap-rails compatibility issue. Furthermore, there are several methods throughout the gem that rely on **options
merging, and reverting those implementations to use options = {}
isn't a mechanical one-to-one replacement.
I think the best course of action is to admit defeat and cut a release that drops support for 2.6 (and maybe even 2.7 and 3.0, since those versions are EOL).
We should probably just cut a major version then that raises the floor to Ruby 3.1, to match Rails 8.
Happened with https://github.com/hotwired/turbo-rails/commit/5038ed8fcf046f9dbc03b959280a747ee67a08ae#diff-45934cb0c9b4dc0fdd1aa4e780742e07541f16cb60835e1b1330a56d1b0f18f1R9
https://github.com/hotwired/turbo-rails/blob/780ee0da511a3d104683b6852ee00594569109e2/turbo-rails.gemspec#L12