search

howanghk / homebridge-ewelink

Homebridge plugin to control Sonoff relays with OEM firmware
MIT License
81 stars 46 forks source link

Don't Download This Plugin - Read on... #128

Open mkormendy opened 5 months ago

mkormendy commented 5 months ago

Just download the actively maintained plugin here: https://github.com/bwp91/homebridge-ewelink <- this is the actively maintained, Homebridge verified, repo

bwp91 commented 5 months ago

this is very old. “original” is wrong here since my plugin is based off howanghk work.

i wouldn’t consider myself the original author

mkormendy commented 5 months ago

Well that's odd .. because, when I looked up the fork tree .. it shows your plugin forked from where he forked it from.

Screenshot 2024-01-05 at 7 37 56 PM

The README is linked back to yours though too:

Screenshot 2024-01-05 at 7 40 28 PM
bwp91 commented 5 months ago

https://github.com/bwp91/homebridge-ewelink/issues/69

mkormendy commented 5 months ago

Ahh okay, well still not sure how to address github's issue with the fork chain I see.

And all of your work on the plugin overall, is really what should be recognized and referenced here.

bwp91 commented 5 months ago

Still not sure the need for the "do not download" warning issue on this plugin?

mkormendy commented 5 months ago

You didn't endorse the warning. That's all you need to worry about. 😀

howanghk commented 5 months ago

Thanks for bringing up this. Since my ewelink device stopped working in early 2020, I do not have the incentive to work on this plugin as I cannot use it myself. I really appreciate bwp91's work, which basically rewrite everything beautifully from scratch. And the move to take over the original repo is brilliant, this helps new user get to a working actively maintained plugin quicker.

I think I should update this repo one last time, adding a note in the README directing users to bwp91's repo, and then archive this repo for good.

bwp91 commented 5 months ago

which basically rewrite everything beautifully from scratch

it looks like this now, but if was several enhancements and iterations of your plugin howanghk, hence the credit in my readme footer.

mkormendy commented 5 months ago

This seems like an appropriate solution. You both have contributed to this project and historical credit is honored.