search

hoyois / plugin-to-html5

Plug-in to HTML5 conversion scripts
http://hoyois.github.com/safariextensions/clicktoplugin/killers.xhtml
37 stars 24 forks source link

MTV Networks killer doesn't appear to function on individual Daily Show pages, for instance #11

Closed nickheer closed 10 years ago

nickheer commented 10 years ago

As an example, the video on this page is not correctly replaced with this HTML5 video. I think the config.xml file is no longer being found correctly, but I am also very bad at figuring out where bugs reside, so I'm probably wrong.

At any rate, the killer does work correctly on "full episode" pages, so I'm confused.

Edit: It's not that the config.xml file can't be found any more, but rather that there's some internal trickery going on for the archive video pages which is different to the full episode pages:

In …context11… (the archive page feed):

<player>
<feed>http://tdslocal/feeds/video_player/mrss?uri={uri}</feed>

In …context5… (a full episode feed):

<player>
<feed>http://shadow.comedycentral.com/feeds/video_player/mrss/?uri={uri}</feed>

Because the first is essentially a localhost-style URL, it fails. Perhaps some js to replace http://tdslocal/ with http://shadow.comedycentral.com/ may resolve this (though I haven't checked as I'm terrible at Javascript).

This appears to be similar on Colbert Nation videos (though replace context11 with context8, and context5 with context7 in the above examples).

Edit 2: I see that I opened this on plugin-to-html5 instead of clicktoplugin, which means that what I was referencing is different between the versions. I replaced the copy of MTVNetworks.js in ClickToPlugin with the one in plugin-to-html5 and it functions correctly. So, I suppose this is an issue with the copy of MTVNetworks.js in ClickToPlugin.

Sorry, I'm bad at bug reporting.

hoyois commented 10 years ago

Thanks for the reminder! I should have updated CTP with the new killers weeks ago. I was delaying the update because I wanted to improve other stuff as well, but I will release an update asap now.

hoyois commented 10 years ago

Fixed in CTP 2.9.1.