Closed bkmgit closed 1 year ago
Out of curiosity, what was the error?
Giving the --cores
option has been mandatory since v5.11. It throws
Error: you need to specify the maximum number of CPU cores to be used at the same time with --cores.
This PR looks good, although we're introducing the flag (by necessity) without saying anything about it. Pedagogically, it would be good to run without --cores
the first time, then at line 88, display the error and share the "fix."
After this first instance, it looks like short flags are given; for consistency, we can convert --cores 1
to -c 1
.
Have used short flags after the first invocation.
Not including --cores 1 does not seem to have much pedagogical value as it is specific to this software package rather than something that is generally used. The time could be used for other activities. Have added an explanation for why --cores 1 is required.
@tkphd Can you take a look at this again. The changes can probably also be made to the original repository.
Also, you should replace -j
with -c
in the keypoints
in the YAML header of 07-resources.md
(line 12).
@tkphd @tobyhodges Think this is ok now.
Set number of cores to prevent an error