rm `pkg-config` dependency at `autogen.sh` time

hpc / charliecloud

Now hosted on GitLab.

https://gitlab.com/charliecloud/main

Apache License 2.0

312 stars 60 forks source link

rm `pkg-config` dependency at `autogen.sh` time #1845

Closed reidpr closed 9 months ago

reidpr commented 9 months ago

PR #1784 introduced a dependency on pkg-config at autogen.sh time. Even though it’s not great that we always require pkg-config to find libfuse3 (see issue #1844), we definitely don’t want to require it unconditionally at autogen.sh time. This PR moves the dependency to configure time and only if --with-libsquashfuse=yes (the default) or a path.

reidpr commented 9 months ago

The error message if the dependency is not met is quite misleading:

 configure.ac:304: error: possibly undefined macro: AC_CHECK_LIB
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:504: error: possibly undefined macro: AC_CHECK_HEADER
autoreconf: error: /usr/bin/autoconf failed with exit status: 1