search

hpcc-systems / Visualization

HPCC JavaScript Framework
https://hpcc-systems.github.io/Visualization/
Other
93 stars 62 forks source link

Line Chart w/Chart Panel Colors #3078

Closed lucashby closed 5 years ago

lucashby commented 5 years ago

When using a line chart in a chart panel, there seems to be a slight discrepancy between the colors in the legend and the colors of the lines. When styling the lines a little thicker, this becomes more obvious.

GordonSmith commented 5 years ago

@jbrundage I thought this was resolved with: https://github.com/hpcc-systems/Visualization/pull/2986 can you follow up for specific example?

jbrundage commented 5 years ago

@lucashby What properties are you using on the Line Chart? Have you set the interpolate and/or interpolateFill properties?

lucashby commented 5 years ago

Here is our initialization code:

vm.numberCrashesByAgeAndSex = new vm.hpcc.Layout.ChartPanel()
    .widget(new vm.hpcc.Chart.Line().paletteID('cc-ageSex').tooltipValueFormat('').xAxisGuideLines(false).yAxisGuideLines(false).pointShape('rectangle'))
    .target('numberCrashesByAgeAndSexDiv')
    .title('Age')
    .titleVisible(false)
    .legendVisible(true)
    .legend_showSeriesTotal(true)
    .legend_showLegendTotal(true);
GordonSmith commented 5 years ago

@lucashby can you do a sanity check that you do have the #2986 fix (which first showed up in @hpcc-js/chart v2.4.1)

jbrundage commented 5 years ago

@GordonSmith I've confirmed that he does have the fix and there's a bug that I'm working on now.