hpi-schul-cloud / schulcloud-server

Schulcloud-Verbund-Software-Server
GNU Affero General Public License v3.0
73 stars 19 forks source link

An in-range update of csv-parse is breaking the build 🚨 #826

Closed greenkeeper[bot] closed 4 years ago

greenkeeper[bot] commented 4 years ago

The dependency csv-parse was updated from 4.5.0 to 4.6.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

csv-parse is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - βœ… **codecov/project:** No report found to compare against ([Details](https://codecov.io/gh/schul-cloud/schulcloud-server/commit/ca1bdf1de932bf54b15b1b81a8a002acbaa6d792)). - ❌ **Travis CI - Branch:** The build **failed**.

Commits

The new version differs by 11 commits.

  • 007adfb Bump to version 4.6.0
  • 5f77c58 skip_lines_with_empty_values: handle non string value
  • 886d45b skip_lines_with_empty_values: handle non string value
  • 06afdb1 assert_error: default to deep equal assertion
  • 2dd8938 assert_error: test boolean
  • 0b21b68 assert_error: non exhaustive by default
  • 3dfe906 Update index.js
  • f39c484 field.toString().trim()
  • e887eef errors: expose INVALID_OPENING_QUOTE
  • 3c8e1f3 tests: new error assertion framework
  • 94429af buffer: serialize to json as string

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 4 years ago

After pinning to 4.5.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 4 years ago

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 3 commits.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Commits

The new version differs by 2 commits.

  • 4959359 Bump to version 4.6.2
  • 0a695e6 context: null column when columns number inferieur to record length

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Commits

The new version differs by 4 commits.

  • f134854 Bump to version 4.6.3
  • 6136fd9 lint: integrate eslint
  • 4959359 Bump to version 4.6.2
  • 0a695e6 context: null column when columns number inferieur to record length

See the full diff

malcm commented 4 years ago

Will be solved here https://github.com/schul-cloud/schulcloud-server/pull/829