search

hpi-swa-lab / qinoq

Create wonderful scrollytellings inside of lively.next ❄
MIT License
2 stars 0 forks source link

Sequences overlap #1044

Closed linusha closed 3 years ago

linusha commented 3 years ago

Since changing to having a frame displayed on the last scrollposition of an interactive sequences that are directly positioned after each other overlap. I.e., they are both visible if one is at the last scrollposition of the first sequence.

This should not be the case. When fixing this, a test could be added that checks that only one sequence from a layer is visible at all times.

frcroth commented 3 years ago

How can we prevent this?

linusha commented 3 years ago

I am not sure what causes this. Could it have something do to with the recent change to include the equal so that the last "frame" is visible?

Maybe my explanation was also not clear, those are sequences in the same layer that are directly following each other according to snapping. Snapping being kind of broken could also the culprit.

frcroth commented 3 years ago

It makes sense that that problem occurs because if a sequence goes to 100 and another starts at 100, both will be shown. This was not a problem when the sequences were not rendered at 100% (which was a sensible decision). We can fix this by reverting that or by not drawing sequences at 0%.