Updates for Pharo12 deprecated methods.

hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.

MIT License

94 stars 68 forks source link

Updates for Pharo12 deprecated methods. #629

Closed hernanmd closed 6 months ago

hernanmd commented 6 months ago

This PR introduces two small changes to use updated versions of deprecated methods in Pharo 12, avoiding Debugger windows when running in interactive mode.

Use tags instead of classTags (deprecated in Pharo12)
Use Author fullName: instead of setAuthor (deprecated in Pharo12).
Changes in .json files are just a re-ordering of properties.

fniephaus commented 6 months ago

Thanks for the PR, @hernanmd. Any way we could clean up the diff and make sure only relevant changes are in the PR. That'd be great and simplify reviewing. Thanks!

And oh no, another set of deprecations in Pharo-12. Could you please take a look at this @theseion?

hernanmd commented 6 months ago

Thanks for the PR, @hernanmd. Any way we could clean up the diff and make sure only relevant changes are in the PR. That'd be great and simplify reviewing. Thanks!

I would need to check because those were set automatically but I have no idea what was the issue there. I guess @jecisc was probably working on it?

And oh no, another set of deprecations in Pharo-12. Could you please take a look at this @theseion?

theseion commented 6 months ago

Thanks @hernanmd. I've cleaned up the PR. @fniephaus please review and merge.

@fniephaus I fear at some point we'll see a breaking change in the VCS format (e.g., the .categories file). I don't know how to deal with that. For Fuel, I've completely abandoned compatibility and have a dedicated branch for Pharo12. I don't think that's a good option for SmalltalkCI though. Maybe we could convince the Pharo devs to ensure that VCS files remain compatible with previous releases.

fniephaus commented 6 months ago

I've cleaned up the PR. @fniephaus please review and merge.

Thanks a lot, Max! Next drink is on me ;)

Maybe we could convince the Pharo devs to ensure that VCS files remain compatible with previous releases.

That'd be good. Some level of backward compatibility is required to allow a consistent, multi-version CI experience. Alternatively, we could consider going back to the fileIn format, unless Pharo devs have broken or will break that as well.

theseion commented 6 months ago

That'd be good. Some level of backward compatibility is required to allow a consistent, multi-version CI experience. Alternatively, we could consider going back to the fileIn format, unless Pharo devs have broken or will break that as well.

I'll bring it up when I get the chance.