search

hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.
MIT License
94 stars 68 forks source link

fix: change directory for Coveralls report #630

Closed theseion closed 6 months ago

theseion commented 6 months ago

In order to use git commands for generating the Coveralls report, the script needs to cd to SMALLTALK_CI_HOME first.

Fixes #626

fniephaus commented 6 months ago

@theseion I had to revert this on master because it's causing builds like this one to fail. I'm not even sure this is the correct fix: SMALLTALK_CI_BUILD is the temp directory for the actual build. With git, we want to get info from the source repo. Maybe instead, we should make export_coveralls_data more robust so that it does not fail if not in a git repo?

theseion commented 6 months ago

Oh, I see... I used SMALLTALK_CI_HOME but the coveralls build is run against the tested repository of course. We should probably cd to where the .ston file is located. That's a good bet for where the repository is. And then don't write a broken file, of course. I'll open a new PR.