[Bug]: GToolkit Download Target Should Include Zip Extension

hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.

MIT License

94 stars 68 forks source link

[Bug]: GToolkit Download Target Should Include Zip Extension #642

Closed seandenigris closed 3 months ago

seandenigris commented 3 months ago

Errors like the following were happening because the folder was being passed to curl instead of the file: Starting GToolkit build... Downloading GToolkit64-release image... curl: (23) Failure writing output to destination curl failed to download https://github.com/feenkcom/gtoolkit/releases/download/v1.0.773/GlamorousToolkit-MacOS-aarch64-v1.0.773.zip to '~/Repositories/smalltalkCI/_cache/GlamorousToolkit-MacOS-aarch64-v1.0.773.zip'.

seandenigris commented 3 months ago

Since the GT check passed, and I only edited the GT script, I'm assuming the failing Pharo 3 check is unrelated.

theseion commented 3 months ago

@fniephaus looks like some branch protection policy that prevents me from merging.

fniephaus commented 3 months ago

@fniephaus looks like some branch protection policy that prevents me from merging.

Ok, I think I just gave you permission to merge PRs to master. Let me know if there's still any issue :)

seandenigris commented 3 months ago

Thanks everyone!