hql287 / Manta

🎉 Flexible invoicing desktop app with beautiful & customizable templates.
https://www.getmanta.app
GNU Lesser General Public License v3.0
5.28k stars 478 forks source link

VAT ID in profile form #254

Open rrussi opened 6 years ago

rrussi commented 6 years ago

Prerequisites

Having a VAT ID in the company description header is mandatory for some countries. The proposal is to add a "VAT ID" text field in the company profile form.

Expected Behavior

The VAT ID would be saved as any other company data.

Current Behavior

No VAT ID field

Context

Company profile form

Your Environment

hql287 commented 6 years ago

@rrussi: You're right. There's no TaxID field under the profile form at the moment. However, you can achieve the same thing by doing this:

Toggle TaxID Field

But I guess I forgot to output it to the templates 🙈 Will make a PR for this, thanks for reporting the issue.

Update: Fixed with #255, templates will display TaxID when it's available.

hql287 commented 6 years ago

Also, the way Manta handles Tax at the moment is that everything that's related to Tax goes with the invoice, instead of the company profile. The rationale was that if an invoice doesn't have tax applied then probably it shouldn't display any tax information at all.

I noticed that you're from Italy (from your profile), are you required to display the TaxID of your company even though the invoice that you're creating doesn't have any tax applied to it?

Do you think the current implementation of tax handling works for you? if not how would you want it to change?

rrussi commented 6 years ago

@hql287, in Italy is mandatory to show the Tax ID in the company profile header. For example :

MyCompany Srl (Name) Via Masone, 9 (Address 1) 24121 Bergamo (BG) (Address 2) P. IVA: 03887650160 (TAX ID) e-mail: info@mycompany.com (EMAIL)

In this case TAX ID is not related to the invoice but is related to the company profile. It's an identifier.

hql287 commented 6 years ago

@rrussi So you can have invoices with no tax applied to the items in it but still have to display the Tax ID with your company profile?

If that's the case then maybe I should move the Tax ID field under the company profile

rrussi commented 6 years ago

I think we'll need both. The TAX ID in the company profile in Italy is mandatory. The TAX ID in the invoice would be mandatory as well because for example in Italy the tax is called "IVA", in england "VAT".

hql287 commented 6 years ago

I think you misunderstood what I meant. The current Tax field in the form is composed of 3 inputs: TaxID, TaxAmount and TaxMethod. What I meant was that maybe I should move this TaxID to the profile area instead, so that the Tax field in the form should only contains Tax Amount and TaxMethod.

What do you think?

hql287 commented 6 years ago

@rrussi: Friendly ping.

rrussi commented 6 years ago

Ok, I misunderstood. I think what you propose is correct.

hql287 commented 6 years ago

Ok, I'll make sure to include this change in the next release (next Friday) because today I'm releasing v1.1.4