search

hramenko / thtmlviewer

Automatically exported from code.google.com/p/thtmlviewer
Other
0 stars 0 forks source link

Bug in TFVBase.BumpHistory() introduced during migration from original 9.44 #366

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I am still using old 9.44 version of THtml component written by  David Baldwin. 
Recently I switched to a new version 11.4 maintained by HtmlViewer Team. One 
thing I noticed, in the new version the first load of HTML document into 
FrameViewer doesn't get into the history of URLs. After digging inside, I 
traced the issue to this line in TFVBase.BumpHistory() procedure: 

 if (FHistoryMaxCount > 0) and (OldFrameSet.FCurrentFile <> '') then

Originally (version 9.44) it was:

if (FHistoryMaxCount > 0) and (CurFrameSet.FCurrentFile <> '') then

After changing it back, the normal behavior was restored. Please can you review 
this change, it looks like a bug because on the first call 
"OldFrameSet.FCurrentFile" is always empty. I checked the latest version 
115-r472 and it has it too, although I didn't try to compile it and use.

Original issue reported on code.google.com by ser...@usa.com on 22 Jul 2014 at 7:43

GoogleCodeExporter commented 9 years ago 
Thanks for digging inside and spotting this issue.

r476 applies your fix.

Original comment by OrphanCat on 22 Jul 2014 at 8:17