vtfm instruction broken in Interpreter

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.

https://www.ppsspp.org

Other

11.44k stars 2.19k forks source link

vtfm instruction broken in Interpreter #12109

Closed hrydgard closed 5 years ago

hrydgard commented 5 years ago

Falling this instruction back to interpreter on current master using the JIT debug tools breaks graphics in GTA: LCS pretty badly. Probably some fallout from @unknownbrackets prefix fixes: https://github.com/hrydgard/ppsspp/commits/ec7cffa847 , should be fairly easy to track down.

unknownbrackets commented 5 years ago

Dumb mistake, I think I even remember copy/pasting the ternaries and thinking "I'll need to change this" but then clearly forgot after testing something (may have found a bug elsewhere.)

-[Unknown]